Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D9 Migration #593

Merged
merged 2 commits into from
Jul 19, 2023
Merged

D9 Migration #593

merged 2 commits into from
Jul 19, 2023

Conversation

marlo-longley
Copy link
Contributor

@marlo-longley marlo-longley commented Jul 10, 2023

Closes #569

@marlo-longley marlo-longley force-pushed the d9-migration branch 2 times, most recently from 39c55c4 to 1bd1e83 Compare July 11, 2023 19:03
@marlo-longley marlo-longley marked this pull request as ready for review July 11, 2023 19:06
config/settings.yml Outdated Show resolved Hide resolved
@marlo-longley
Copy link
Contributor Author

I updated this PR to conditionally work based on a D9_LAUNCH ENV variable. If this approach seems OK I will:

  1. Open a puppet PR to add D9_LAUNCH = false (or, just ask Ops to add the var entirely at launch time)
  2. Communicate with Ops about the need to flip this flag to true at launch time
  3. Open a ticket in this repo to clean up the conditionals after launch

@jcoyne
Copy link
Contributor

jcoyne commented Jul 17, 2023

@marlo-longley that sounds like a good approach to me.

@marlo-longley marlo-longley changed the title [HOLD til 7/31] D9 Migration D9 Migration Jul 19, 2023
@marlo-longley
Copy link
Contributor Author

marlo-longley commented Jul 19, 2023

This PR in Puppet is approved and I communicated with Rob from Ops -- he will merge it Sunday night 7/31.
https://github.com/sul-dlss/puppet/pull/9693

I also created a cleanup ticket and assigned myself: #596

That should mean we can merge in this code now and it won't take effect til after the Puppet merge.

Copy link
Contributor

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we have a ticket for cleanup post launch? Cleanup in #596

@jcoyne jcoyne merged commit 7cf003c into master Jul 19, 2023
2 checks passed
@jcoyne jcoyne deleted the d9-migration branch July 19, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use new Drupal 9 endpoints for Library Website search results
3 participants